Ecosim and Ecospace scenario dialogues can ask multiple times to load a scenario

[joeb]

This can get pretty confusing but basically. Turn off the Save window layout option open a model and go straight to Run ecopsace you will be asked for an Ecosim and Ecospace scenario at least twice. Click around in the interface once you have the Run ecospace interface up you may be asked to reload the scenarios. This also happens when the Save window layout option is on but it seem even more confusing then because things are loading in the background and you dont know why you are being asked to load a scenario.

[administrator]

Parent of #48

[jeroens]

Debug findings:

1. Loading Ecospace will cause PoolColors? to be loaded. (in RunEcospace?.InitColors?())
2. This will cause the color manager to load colors and to stick them in the ecopath groups. This will cause Variable validation at Ecopath level, causing the core state monitor to enter EcopathLoaded? state, forgetting that Ecospace was just loaded!
3. The Core controller then tries to revive the Ecospace state by showing the load dialogs.
4. Ecospace will eventually be loaded. The dialogs have appeared twice.

[jeroens]

Possible solutions at load dialog level, but this needs to be thought out really well:

1. There is no need to physically reload scenarios (either sim or space) when Ecopath has been modified. Once Ecopath has ran, the current sim and space scenarios are still valid and usable.

2. Maybe the ecosim and ecospace dialogs need to be invoked explicitly rather than implicitly from nav tree manipulation. That way, a current loaded scenario remains valid until the user actively decides to load a different scenario.

3. The Core controller is unable to distinguish whether the user would want to keep using a current sim/space scenario or would like to load a new scenario

However, these changes may have conceptual implications...

[jeroens]

Load Ecosim dialog toolbar button was hard-wired to invoke the dialog, while it was also tied to an underlying global command. This caused the dialog to appear thrice when invoked from the toolbar. This has been fixed.

[jeroens]

For now behaviour is kept as is. Current scenarios are kept when possible.